Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev and peer dependencies are not right #29

Open
mltsy opened this issue Aug 24, 2017 · 1 comment
Open

Dev and peer dependencies are not right #29

mltsy opened this issue Aug 24, 2017 · 1 comment

Comments

@mltsy
Copy link
Collaborator

mltsy commented Aug 24, 2017

The Peer Dependency on chai is way too strict (~4.0.1)

In trying to fix this, I ran into unmet peer dependencies in the devDependencies graph, stemming from eslint-config-airbnb. I replaced it with eslint-config-airbnb-base since this project doesn't depend on react, and added the remaining peer (eslint-plugin-import), but was unable to get eslint to work (./node_modules/.bin/eslint src/assertions/text.js now complains that it Cannot find module babel-eslint) I'm curious whether we need eslint at all? I have never used it before, so I many just be doing something wrong, and wanted to ask what it is there for, and how I should be testing to make sure it works! :)

Could it just be something a developer can install and run globally? If we don't need it as part of the project, I'll remove it. If we do, I'll try to fix it by adding all the necessary dependencies. I just wanted to find out how/why it got to the current state before I made any more changes...

@mltsy
Copy link
Collaborator Author

mltsy commented Aug 24, 2017

^ @marcodejongh (I assume you will have the best insight on these dependencies) 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant