-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript + API Cleanup + Simple Components #30
Open
marchaos
wants to merge
26
commits into
master
Choose a base branch
from
typescript
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added example and simple Cypress test * Added prettier config * Cleanup
* Fixed TS types for AutoSizedStickyTree * Fixed build so we include ts definitions.
* Fixed build and tests
* Added basic test for StickyList * Fixed some prop types for StickyTree * Added example for List
…u supplied, rather than just the id to avoid having to look up the node again.
marchaos
changed the title
Typescript + Cleanup
Typescript + API Cleanup + Simple Components
Dec 1, 2020
…ky tree element (so that you can override it with CSS)
…h_height Prop for not setting inline width height
…sing top issues. Converted to RC components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted all files to TS + Small cleanup to API + new simpler components
Changes
StickyList
andAutoSizedStickyList
which simplifies the API for those that just want to render a list. See CitiesList.tsx in examples.npm start
Breaking Changes
defaultRowHeight
prop is now justrowHeight
onRowsRendered
props for startNode and endNode are now of typeEnhancedStickyTreeNode<TNodeType>
getChildren
, e.g.