[Bug] Search input cannot be reselected

[ramezrafla]

If we run a search, then click on a cell, we can't re-select the search input.
In fact, selected cells are offset vertically by one.

The search functionality looks like it was added (uses jQuery and different coding conventions). Seems it's in conflict with the keyboard event managers.

However, ethercalc does not have this problem (can't find the source in the ethercalc repo to compare).

Do you guys remember the change you made?

[eddyparkinson]

Allow shift+enter to search backwards
pjrobertson committed to audreyt/ethercalc on 27 May 2015

Don't search hidden rows/cols
pjrobertson committed to audreyt/ethercalc on 20 May 2015

Add a search bar to allow searching a sheet
pjrobertson committed to audreyt/ethercalc on 20 May 2015

https://github.com/audreyt/ethercalc/search?q=search&type=Commits&utf8=%E2%9C%93

[ramezrafla]

Thanks @eddyparkinson

I checked and all these are already committed in this SocialCalc repo (in fact, I copied over all the socialcalc files from ethercalc and face the same issue).

I think I am going to remove the search feature for now until we understand better how input handling is done.

[ramezrafla]

Further, the only jQuery dependency is the search feature, I recommend it either becomes vanilla JS or gets removed.

[eddyparkinson]

the GUI formulas, e.g. =SELECT("Female","-,Male,Female")
require JQuery-UI

audreyt/ethercalc@8f3cc34

[ramezrafla]

I'll check to see if those formulas are in the socialcalc repo or just the ethercalc one

[marcelklehr]

they are in the socialcalc repo, afaik