You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
If filemtime returns 0, the ETag hash is always the same and therefore every file attempted to serve 304's.
If filemtime is run on any file inside the container that's not part of the host mount volume (like /start.sh) it returns the correct value.
Any thoughts on the best way to resolve this? Here are a couple ideas:
Modify your code to check a flag and short circuit the isModified function if set, (HTTP_IF_MODIFIED_SINCE or HTTP_IF_NONE_MATCH could be set to SKIP or EXIT in .htaccess instead of an actual timestamp)
If lastModifiedTime in isModified is 0 don't set any headers, skip out and return false
If you have any other ideas I'd like to hear them, I would be happy to put together an MR based on what you want to do.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If
filemtime
returns 0, the ETag hash is always the same and therefore every file attempted to serve 304's.If
filemtime
is run on any file inside the container that's not part of the host mount volume (like/start.sh
) it returns the correct value.Any thoughts on the best way to resolve this? Here are a couple ideas:
isModified
function if set, (HTTP_IF_MODIFIED_SINCE
orHTTP_IF_NONE_MATCH
could be set toSKIP
orEXIT
in .htaccess instead of an actual timestamp)lastModifiedTime
inisModified
is 0 don't set any headers, skip out and return falseIf you have any other ideas I'd like to hear them, I would be happy to put together an MR based on what you want to do.
The text was updated successfully, but these errors were encountered: