Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate text if you run convert_to_parent_pixel_bounds or convert_to_coords twice #530

Open
rwood-97 opened this issue Nov 18, 2024 · 1 comment
Labels
bug Something isn't working text on maps Integrating text detection and recognition task(s)

Comments

@rwood-97
Copy link
Collaborator

Describe the bug
At the moment, we store out text predictions as a list in dictionary. If you run convert_to_parent_pixel_bounds or convert_to_coords twice, it will just append the predictions onto the existing list so you will have 2x the outputs.

This should be fixed either by starting a fresh list for each time you run convert_to_xx or by converting the list to a set.
Obviously, these solutions still aren't ideal and would be better as a data class.

@rwood-97 rwood-97 added the bug Something isn't working label Nov 18, 2024
@github-project-automation github-project-automation bot moved this to Backlog in MapReader Nov 18, 2024
@rwood-97 rwood-97 added the text on maps Integrating text detection and recognition task(s) label Nov 18, 2024
@rwood-97
Copy link
Collaborator Author

Maybe fixed by #536 , check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text on maps Integrating text detection and recognition task(s)
Projects
Status: Backlog
Development

No branches or pull requests

1 participant