Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate Metal triangulated fill outlines performance impact #1869

Closed
stefankarschti opened this issue Nov 15, 2023 · 1 comment
Closed

Reevaluate Metal triangulated fill outlines performance impact #1869

stefankarschti opened this issue Nov 15, 2023 · 1 comment

Comments

@stefankarschti
Copy link
Collaborator

#1780 introduced the MLN_TRIANGULATE_FILL_OUTLINES in fill_bucket.hpp switch to turn triangulated fill outlines on and off.

TODO: Reevaluate performance after Metal shader variations have beed implemented and decide what the MLN_TRIANGULATE_FILL_OUTLINES flag value should be.
@stefankarschti stefankarschti converted this from a draft issue Nov 15, 2023
@stefankarschti stefankarschti changed the title Reevaluate Metal / GL triangulated fill outlines performance impact Reevaluate Metal triangulated fill outlines performance impact Nov 15, 2023
@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Jan 6, 2024

Happy with where it is now.

@sjg-wdw sjg-wdw closed this as completed Jan 6, 2024
@sjg-wdw sjg-wdw moved this from Up Next to Done in MapLibre Native Project Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MapLibre Native Project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefankarschti @sjg-wdw