Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 values of some type are ignored #38

Open
joto opened this issue Jan 29, 2018 · 0 comments
Open

v2 values of some type are ignored #38

joto opened this issue Jan 29, 2018 · 0 comments
Labels
2.x
Milestone
2.0

Comments

@joto
Copy link
Contributor

joto commented Jan 29, 2018

https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L96-L99

Values of type null_value_t, mapbox::util::recursive_wrapper<std::vector<value>>, and mapbox::util::recursive_wrapper<std::unordered_map<std::string, value>>> are simply ignored here. If this is correct, it needs to be documented.
@flippmoke flippmoke added the 2.x label Feb 2, 2018
@flippmoke flippmoke added this to the 2.0 milestone Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@joto @flippmoke