Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDs ignored #37

Open
joto opened this issue Jan 29, 2018 · 1 comment
Open

IDs ignored #37

joto opened this issue Jan 29, 2018 · 1 comment
Labels
Milestone

Comments

@joto
Copy link
Contributor

joto commented Jan 29, 2018

IDs < 0 and IDs not of type int64_t or uint64_t are simply ignored here:
https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L48-L59

Is this correct? If yes, I think it needs to be documented.

@flippmoke
Copy link
Member

I think the core problem is more that we support int64_t and uint64_t id types in our internal geometry.hpp structure as well. We should probably look into only having one of these, but yes it should be documented.

@flippmoke flippmoke added the 2.x label Feb 2, 2018
@flippmoke flippmoke added this to the 2.0 milestone Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants