Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Make dependencies #824

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StefanosChaliasos
Copy link

Hello

This pull request fixes the build script of this project.
Specifically, it adds missing Make dependencies so that the targets of the project are re-generated correctly whenever there are updates to any of the dependent source files.

In this way, the project is incrementally built and we no longer sacrifice time in clean builds (i.e., builds after a make clean).

Note that this fix follows the best practices for tracking dependencies automatically (through gcc -MD)

For more details, see here.
https://www.gnu.org/software/make/manual/html_node/Automatic-Prerequisites.html

@e-n-f
Copy link
Contributor

e-n-f commented Jan 9, 2020

I'm not sure I understand the intent of this change, because the existing -MMD in the Makefile should already be generating the dependencies. Is there a reason to prefer -MD?

@StefanosChaliasos
Copy link
Author

Hello, You're right. -MD is not needed, but the problem is that with the previous Makefile, no dependency files were generated for Objects at line 49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants