Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Edge tiles do not render on pitched map #15442

Closed
LukasPaczos opened this issue Aug 21, 2019 · 1 comment · Fixed by #15461
Closed

Edge tiles do not render on pitched map #15442

LukasPaczos opened this issue Aug 21, 2019 · 1 comment · Fixed by #15461
Assignees
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS release blocker Blocks the next final release
Milestone

Comments

@LukasPaczos
Copy link
Contributor

LukasPaczos commented Aug 21, 2019

When the map is pitched and padded, the tiles on the edge of the screen can fail to render.

@astojilj edit:


@LukasPaczos, thanks for debugging.

Issue is reproducible with release-nectar branch, too. It is not related to padding as it is reproducible with no padding, too.

Camera setup used for reproducing:

latLng = {const mbgl::LatLng &} 
 lat = {double} 59.116898740996106
 lon = {double} 91.565660781803615
zoom = {double} 2.0551126748417214
bearing = {double} 0.74963938256567264
pitch = {double} 1.0471975511965976

width = {uint32_t} 412
height = {uint32_t} 691


The map height is 2418px, top padding is 1000px and pitch is 60.
ezgif com-video-to-gif (11)

/cc @chloekraw @astojilj

@LukasPaczos LukasPaczos added Core The cross-platform C++ core, aka mbgl beta blocker Blocks the next beta release labels Aug 21, 2019
@chloekraw chloekraw added this to the release-queso milestone Aug 21, 2019
@LukasPaczos LukasPaczos added release blocker Blocks the next final release and removed beta blocker Blocks the next beta release labels Aug 21, 2019
@astojilj astojilj changed the title Edge tiles do not render on padded and pitched map Edge tiles do not render on pitched map Aug 22, 2019
@astojilj
Copy link
Contributor

astojilj commented Aug 22, 2019

Issue description and title edit. Issue is not a recent regression, reproducible with release-nectar, too. Not reproducible with JS.

@astojilj astojilj added the GL JS parity For feature parity with Mapbox GL JS label Aug 22, 2019
astojilj added a commit that referenced this issue Aug 23, 2019
Remove unecessary tile coordinate unproject -> project  step.
Unproject+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values.

Fixes: #15442
astojilj added a commit that referenced this issue Aug 23, 2019
Remove unecessary tile coordinate unproject -> project  step.
Unproject+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values.

Fixes: #15442
LukasPaczos pushed a commit that referenced this issue Aug 23, 2019
Remove unecessary tile coordinate unproject -> project  step.
Unproject+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values.

Fixes: #15442

(cherry picked from commit 9eff849)
LukasPaczos pushed a commit that referenced this issue Aug 27, 2019
Remove unecessary tile coordinate unproject -> project  step.
Unproject+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values.

Fixes: #15442

(cherry picked from commit 9eff849)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS release blocker Blocks the next final release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants