cc @chloekraw

Some suggestions:

1. This ratio should have a minimum value. After testing, suggest 0.2 is a best one.
2. Don't suggest any limitation of maximum width for a specific value, it should be decided by users. Consider some developers may need this scale bar with full screen width at bottom of map view.
3. Margins should only affect the maximum width when the view's max X probably out of the screen. If we let margin always affect final width, consider when developer set this value to 0.5 and margin to (20,20), the width should be mapView.bounds.width/2 - margin.x * 2, it is out of expectation and hard to understand at first when the margin affect the final width. We should return an accurate width and let developers change the margin or ratio by themselves.

@julianrex
cc: @chloekraw

@m-stephen

In one scenario, if the ratio is set to 0.5 but then it is loaded in a SplitView where the width becomes 100px, in this case, the width of the scale bar should be close to 100px. If I set the maximum ratio to 1, would it dynamically update the width of the scale bar from 50px to 100px?

Sorry for late reply. @tsuz

In one scenario, if the ratio is set to 0.5 but then it is loaded in a SplitView where the width becomes 100px, in this case, the width of the scale bar should be close to 100px. If I set the maximum ratio to 1, would it dynamically update the width of the scale bar from 50px to 100px?

Correct. After this PR, the scale bar's width will be changed dynamically based on map view's frame when you set the maximum ratio.

@m-stephen

Thanks for confirming!

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.