Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SVG Format #122

Open
AymenStudios opened this issue Nov 23, 2019 · 6 comments · May be fixed by #654
Open

Support SVG Format #122

AymenStudios opened this issue Nov 23, 2019 · 6 comments · May be fixed by #654
Labels
feature request new features that don't exist at all good first issue Good for new contributors invalid/out of scope Not an issue for this project
Milestone

Comments

@AymenStudios
Copy link

Problem

Suggested solution

Possible drawbacks

Possible alternatives

@AymenStudios AymenStudios added the enhancement ideas to improve existing features label Nov 23, 2019
@maoschanz
Copy link
Owner

(A not-described solution fixing a non-existent problem, with no drawbacks or alternatives? 🤔)

I think everything related to shapes/pencil/text/line could be exported as SVG (example of SVG export with the same underlying library), but the other tools (cropping, scaling, blurring, saturation, and selection) are manipulating some GdkPixbuf.Pixbuf objects, which are raster graphics data structures. It's actually a very common format within GNOME technologies, and it's used for copying and pasting, it's also how the app loads files, how it saves files, how it export files, etc.

So i don't know what to do, i'll let that opened, but implementing this would require rewriting 60% of the entire app so you shouldn't expect any progress for like 1 or 2 years lol

@maoschanz maoschanz added feature request new features that don't exist at all and removed enhancement ideas to improve existing features labels Jul 26, 2020
@YalandHong
Copy link

If Drawing is designed to be "a simple drawing application similar to MS Paint", then supporting SVG is not really important. There're lots of developed and well-known apps on Linux for editing vector graphics.

I still want Drawing to keep its simplicity.

@maoschanz
Copy link
Owner

FYI there are various intermediate steps between not understanding SVG at all and being an SVG editor: creating a classic raster image by importing an SVG file for example. And even a full SVG files editing and saving support wouldn't change the ergonomics of the app.

Anyway my answer was:

So i don't know what to do, i'll let that opened, but implementing this would require rewriting 60% of the entire app so you shouldn't expect any progress for like 1 or 2 years lol

@maoschanz maoschanz added the invalid/out of scope Not an issue for this project label Jan 3, 2023
@maoschanz
Copy link
Owner

creating a classic raster image by importing an SVG file for example

well, this already works

i haven't done anything

  • however the app saves it as a wrongly-named PNG (which destroys the original SVG), the fix for this shouldn't be hard
  • add SVG to the "open" and "import" dialogs' file filters

any other svg support is out of scope

@maoschanz maoschanz added the good first issue Good for new contributors label Jan 3, 2023
@maoschanz maoschanz added this to the 1.4.0 milestone Jan 3, 2023
pedropaulosuzuki added a commit to pedropaulosuzuki/drawing that referenced this issue Aug 25, 2024
Allows the file chooser dialog to show and open SVG files.

Partially fixes maoschanz#122.
@pedropaulosuzuki
Copy link

* [ ]  add SVG to the "open" and "import" dialogs' file filters

#654 should take care of that. I personally didn't test if importing an SVG file creates a raster correctly, but I'm trusting you on that one.

@pedropaulosuzuki
Copy link

I think everything related to shapes/pencil/text/line could be exported as SVG (example of SVG export with the same underlying library), but the other tools (cropping, scaling, blurring, saturation, and selection) are manipulating some GdkPixbuf.Pixbuf objects, which are raster graphics data structures.

For cropping and scaling we could change the shape/line/text coordinates and/or size directly. Saturation we could change the object color directly or something. Not sure about blur tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request new features that don't exist at all good first issue Good for new contributors invalid/out of scope Not an issue for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants