From 3623a545da1627b9c127f04af8469f79418af127 Mon Sep 17 00:00:00 2001 From: James Smith Date: Fri, 17 Jan 2025 11:34:53 +0000 Subject: [PATCH 1/3] Organize files into groups of at least 5% of total count --- app/helpers/models_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/models_helper.rb b/app/helpers/models_helper.rb index 1811ef06e..05fdcaa88 100644 --- a/app/helpers/models_helper.rb +++ b/app/helpers/models_helper.rb @@ -2,7 +2,7 @@ module ModelsHelper def group(files) return {} if files.empty? sections = {} - min_section_size = 2 + min_section_size = (files.count * 0.05).round min_prefix_length = 3 names = files.map { |it| it.filename.downcase } slice = names.map(&:length).max From d9a90d54bb1054d6dd9698db9037d2eb6116ae3e Mon Sep 17 00:00:00 2001 From: James Smith Date: Fri, 17 Jan 2025 11:40:23 +0000 Subject: [PATCH 2/3] Add asterisks on group titles to imply file-like grouping --- app/views/models/show.html.erb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/models/show.html.erb b/app/views/models/show.html.erb index 64bc3c686..668854b17 100644 --- a/app/views/models/show.html.erb +++ b/app/views/models/show.html.erb @@ -28,7 +28,7 @@ <%= render partial: "file", collection: @groups.delete(nil) %> <% @groups.each_pair do |group, files| %> -

<%= group.careful_titleize %>

+

<%= group.strip.careful_titleize %>*

<%= render partial: "file", collection: files %>
@@ -134,7 +134,7 @@ Top <%= link_to t(".files_card.bulk_edit"), bulk_edit_model_model_files_path(@model), class: "btn btn-secondary" if policy(@model).edit? %> From 4804f6076ed828e89cc16689253bd0abef1589ad Mon Sep 17 00:00:00 2001 From: James Smith Date: Fri, 17 Jan 2025 12:11:38 +0000 Subject: [PATCH 3/3] set minimum group size --- app/helpers/models_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/models_helper.rb b/app/helpers/models_helper.rb index 05fdcaa88..ef63424bd 100644 --- a/app/helpers/models_helper.rb +++ b/app/helpers/models_helper.rb @@ -2,7 +2,7 @@ module ModelsHelper def group(files) return {} if files.empty? sections = {} - min_section_size = (files.count * 0.05).round + min_section_size = [2, (files.count * 0.05).round].max min_prefix_length = 3 names = files.map { |it| it.filename.downcase } slice = names.map(&:length).max