-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD VIZ ShonenJump #747
base: master
Are you sure you want to change the base?
ADD VIZ ShonenJump #747
Conversation
I have a paid membership to VIZ Manga (but not SJ) as well as a couple of volumes of manga and many issues of WSJ in my library. All I get when I try to load VIZ on, after logging on with the internal web browser is red |
If you tried Haruneko release you basically ran something without VIZ experimental support, this error is expected. Its an empty shell in release. You need to download source from this branch, install NodeJS, install Git, run "npm install" once in source folder, and run two commands to launch haruneko server and haruneko client when you want to run Haruneko
|
Thanks. Got it installed and running, though I did run A couple things:
Also, despite subscribing to VIZ Manga, I am only seeing the free chapters. And if a series is one I own, I am unable to download any chapters as I cannot find a seperate listing. One exception is Oishinbo, which is named differently for the volumes and the chapters. (Oishinbo vs Oishinbo A La Carte) And Weekly Shonen Jump chapters aren't showing up. I assume these are pretty hidden on the website and only visible to longstanding users. In |
* Fixed getting volumes * Add WeekLyShonenJump issues in manga list * Fixed getting Shonenjump mangas * Extended page script delay to get pages from WSJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- package.json: Language not supported
Comments skipped due to low confidence (2)
web/src/engine/websites/VizShonenJump.ts:11
- [nitpick] The type name 'PagesInfos' should be renamed to 'PageInfos' to be consistent with the singular form used elsewhere.
type PagesInfos = {
web/src/engine/websites/VizShonenJump.ts:22
- [nitpick] The variable name 'PagesScript' could be more descriptive, such as 'FetchPagesScript'.
const PagesScript = `
Tests have been made ❤️ . Ready for review