Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD VIZ ShonenJump #747

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

ADD VIZ ShonenJump #747

wants to merge 24 commits into from

Conversation

MikeZeDev
Copy link
Contributor

@MikeZeDev MikeZeDev commented Aug 15, 2024

Tests have been made ❤️ . Ready for review

@MikeZeDev MikeZeDev changed the title VIZ : first attempt VIZ ShonenJump : first attempt Aug 15, 2024
@erictbar
Copy link

erictbar commented Oct 2, 2024

I have a paid membership to VIZ Manga (but not SJ) as well as a couple of volumes of manga and many issues of WSJ in my library. All I get when I try to load VIZ on, after logging on with the internal web browser is red U_ error

@MikeZeDev
Copy link
Contributor Author

I have a paid membership to VIZ Manga (but not SJ) as well as a couple of volumes of manga and many issues of WSJ in my library. All I get when I try to load VIZ on, after logging on with the internal web browser is red U_ error

If you tried Haruneko release you basically ran something without VIZ experimental support, this error is expected. Its an empty shell in release.

You need to download source from this branch, install NodeJS, install Git, run "npm install" once in source folder, and run two commands to launch haruneko server and haruneko client when you want to run Haruneko

npm run server:dev --workspace app/nw
npm run launch:dev --workspace app/nw

@erictbar
Copy link

erictbar commented Oct 3, 2024

Thanks. Got it installed and running, though I did run npm run serve:dev --workspace web instead of npm run server:dev --workspace app/nw as that resulted in an error.

A couple things:
The listings prioritize the 14 series I own chapters for, but gives an error in the item list when clicking on any of them:

TypeError: Cannot read properties of undefined (reading 'substring')
Cannot read properties of undefined (reading 'substring')

Also, despite subscribing to VIZ Manga, I am only seeing the free chapters.

And if a series is one I own, I am unable to download any chapters as I cannot find a seperate listing. One exception is Oishinbo, which is named differently for the volumes and the chapters. (Oishinbo vs Oishinbo A La Carte)

And Weekly Shonen Jump chapters aren't showing up. I assume these are pretty hidden on the website and only visible to longstanding users. In My Library they are at a seperate URL https://www.viz.com/account/library/sj sorted by year, for example, https://www.viz.com/account/library/sj/2018 with an example issue Dec 10, 2018 (Last Issue) at https://www.viz.com/shonenjump/weekly-shonen-jump-volume-430/issue/promo/16775?action=read

@ronny1982 ronny1982 added Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) and removed Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) labels Oct 3, 2024
@ronny1982 ronny1982 added Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) and removed Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) labels Oct 4, 2024
@github-actions github-actions bot requested a deployment to haruneko (Preview) October 4, 2024 06:22 Abandoned
@ronny1982 ronny1982 added Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) and removed Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) labels Oct 4, 2024
@MikeZeDev MikeZeDev marked this pull request as ready for review October 8, 2024 08:59
@MikeZeDev MikeZeDev changed the title VIZ ShonenJump : first attempt ADD VIZ ShonenJump Oct 8, 2024
@ronny1982 ronny1982 removed the Deploy PR Add this Label to deploy a build of this Pull-Request to CloudFlare (for Preview/Testing) label Nov 5, 2024
@Sheepux Sheepux requested a review from Copilot November 22, 2024 13:40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • package.json: Language not supported
Comments skipped due to low confidence (2)

web/src/engine/websites/VizShonenJump.ts:11

  • [nitpick] The type name 'PagesInfos' should be renamed to 'PageInfos' to be consistent with the singular form used elsewhere.
type PagesInfos = {

web/src/engine/websites/VizShonenJump.ts:22

  • [nitpick] The variable name 'PagesScript' could be more descriptive, such as 'FetchPagesScript'.
const PagesScript = `
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants