You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our use case read the full unified logs but does not bother about all the logs.
Could be great if we could skip the message formating while reading, but be able and turn the message field of LogData into a message() function that actually Lazy compute the full formatted message on demand.
I wanted to dig this possibility and just landed a refacto of the LogData creation code => shindan-io@a43b75e
All our tests are passing just same and fine with this change.
Not sure what I first wanted to do is possible as the log_message formatting sometimes mut the missing parts.
First I'd like to know if you like this mode rust idiomatic style of code (IMHO).
I could have some more rustdiomatic changes to contribute, but perhaps the actual code style was I requirement on your side, that's why I'm asking here.
The text was updated successfully, but these errors were encountered:
Hi,
Our use case read the full unified logs but does not bother about all the logs.
Could be great if we could skip the message formating while reading, but be able and turn the
message
field ofLogData
into amessage()
function that actually Lazy compute the full formatted message on demand.I wanted to dig this possibility and just landed a refacto of the LogData creation code => shindan-io@a43b75e
All our tests are passing just same and fine with this change.
Not sure what I first wanted to do is possible as the
log_message
formatting sometimesmut
the missing parts.First I'd like to know if you like this mode
rust idiomatic
style of code (IMHO).I could have some more
rustdiomatic
changes to contribute, but perhaps the actual code style was I requirement on your side, that's why I'm asking here.The text was updated successfully, but these errors were encountered: