From 1b18a7cb73e56e7f6914f6ee5e7e9f5e70402fcf Mon Sep 17 00:00:00 2001 From: Alex Seaton Date: Mon, 6 Jan 2025 11:10:35 +0000 Subject: [PATCH] Remove .github/ files copied from master that we don't need on 4.4.x --- .github/CODEOWNERS | 2 - .github/workflows/build_steps.yml | 19 ------- .github/workflows/static_analysis.yml | 73 --------------------------- 3 files changed, 94 deletions(-) delete mode 100644 .github/CODEOWNERS delete mode 100644 .github/workflows/static_analysis.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index fef02a69ff..0000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,2 +0,0 @@ -/cpp/ @alexowens90 @willdealtry @poodlewars -/python/ @alexowens90 @willdealtry @poodlewars diff --git a/.github/workflows/build_steps.yml b/.github/workflows/build_steps.yml index 346c5cde97..e0dcab8aa9 100644 --- a/.github/workflows/build_steps.yml +++ b/.github/workflows/build_steps.yml @@ -179,15 +179,6 @@ jobs: name: test_unit_arcticdb_${{matrix.os}} path: cpp/out/install/test_unit_arcticdb* - # We don't do anything with the benchmarks automatically yet, but check that they at least compile and run. - - name: Compile C++ Benchmarks - if: inputs.job_type == 'cpp-tests' - run: cd cpp; cmake --build --preset $ARCTIC_CMAKE_PRESET --target benchmarks -j $CMAKE_BUILD_PARALLEL_LEVEL - - - name: Run C++ Benchmarks - if: inputs.job_type == 'cpp-tests' - run: cpp/out/${ARCTIC_CMAKE_PRESET}-build/arcticdb/benchmarks - # ========================= build-python-wheels (CIBW) steps ========================= - name: Get CIBuildWheel image & metadata if: inputs.job_type == 'build-python-wheels' && matrix.os == 'linux' @@ -371,16 +362,6 @@ jobs: name: crashdump-${{env.distinguishing_name}} path: ${{env.LOCALAPPDATA}}/CrashDumps/ - # Fallback if the clean up at test fixutre tear down fails due to crash or etc - - name: Remove AWS testing account and credentials - if: always() && inputs.persistent_storage == 'true' - run: | - python -c " - from arcticdb.storage_fixtures.s3 import real_s3_sts_clean_up - real_s3_sts_clean_up('${ARCTICDB_REAL_S3_STS_TEST_USERNAME}', '${ARCTICDB_REAL_S3_STS_TEST_ROLE}', '${ARCTICDB_REAL_S3_STS_TEST_POLICY_NAME}') - " - continue-on-error: true - - name: Disk usage if: always() run: set +e ; du -m . "${PARALLEL_TEST_ROOT:-/tmp/parallel_test}" | sort -n | tail -n 100 || true; df -h diff --git a/.github/workflows/static_analysis.yml b/.github/workflows/static_analysis.yml deleted file mode 100644 index 7c439946fc..0000000000 --- a/.github/workflows/static_analysis.yml +++ /dev/null @@ -1,73 +0,0 @@ ---- - name: Coverity Static Analysis - on: - workflow_dispatch: - schedule: - - cron: "0 3 * * *" - - jobs: - polaris-scan: - name: Polaris Coverity Static Analysis - permissions: - packages: write - runs-on: ubuntu-22.04 - env: - VCPKG_NUGET_USER: ${{secrets.VCPKG_NUGET_USER || github.repository_owner}} - VCPKG_NUGET_TOKEN: ${{secrets.VCPKG_NUGET_TOKEN || secrets.GITHUB_TOKEN}} - steps: - - name: Get number of CPU cores - uses: SimenB/github-actions-cpu-cores@97ba232459a8e02ff6121db9362b09661c875ab8 - id: cpu-cores - - - name: Checkout Source - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - name: Setup build dependencies - run: | - sudo apt-get update - sudo apt-get install -y gcc-10 g++-10 make mono-complete libkrb5-dev libsasl2-dev - - - name: Setup VCPKG cache - run: | - . build_tooling/vcpkg_caching.sh - echo -e "VCPKG_BINARY_SOURCES=$VCPKG_BINARY_SOURCES - VCPKG_ROOT=$PLATFORM_VCPKG_ROOT" | tee -a $GITHUB_ENV - - - name: Get CMake - uses: lukka/get-cmake@latest - - - name: CMake configure - uses: lukka/run-cmake@v10.8 - env: - CC: "gcc-10" - CXX: "g++-10" - with: - cmakeListsTxtPath: ${{github.workspace}}/cpp/CMakeLists.txt - configurePreset: linux-release - configurePresetAdditionalArgs: "['-DVCPKG_INSTALL_OPTIONS=--clean-after-build', '-DCMAKE_C_COMPILER=gcc-10', '-DCMAKE_CXX_COMPILER=g++-10']" - - - name: Copy Coverity config - run: cp ${{github.workspace}}/coverity.yaml ${{github.workspace}}/cpp/out/linux-release-build - - - name: Polaris PR Scan - uses: synopsys-sig/synopsys-action@v1.13.0 - with: - polaris_server_url: ${{ vars.POLARIS_SERVER_URL }} - polaris_access_token: ${{ secrets.POLARIS_ACCESS_TOKEN }} - polaris_application_name: "ArcticDB" - polaris_project_name: "ArcticDB-core" - polaris_assessment_types: "SAST" - polaris_prComment_enabled: true - polaris_waitForScan: true - coverity_build_command: make -j ${{ steps.cpu-cores.outputs.count }} - coverity_clean_command: make clean - github_token: ${{ secrets.POLARIS_GITHUB_TOKEN }} - project_directory: ${{github.workspace}}/cpp/out/linux-release-build - include_diagnostics: true - polaris_reports_sarif_create: true - polaris_reports_sarif_groupSCAIssues: true - polaris_upload_sarif_report: true - polaris_prComment_severities: "high,critical,medium,low"