Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event filters for ghost entities are incorrect #245

Open
jagoly opened this issue Dec 23, 2024 · 0 comments
Open

event filters for ghost entities are incorrect #245

jagoly opened this issue Dec 23, 2024 · 0 comments

Comments

@jagoly
Copy link
Contributor

jagoly commented Dec 23, 2024

in main.lua, the event filters are using
{ filter = "ghost", ghost_name = COMBINATOR_NAME } and { filter = "ghost", name = COMBINATOR_NAME }
for ghosts. These are both incorrect, "ghost" is a mode that just accepts EVERY ghost and doesn't take a name.

Rather, they should both be { filter = "ghost_name", name = COMBINATOR_NAME }.

Probably won't make any difference other than making event handling 0.000001% faster, but I noticed it in my own project that used cybersyn's event handling as a reference, so figured I'd put an issue here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant