Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic allow-list does not recognize Pyanodon advanced wagons #142

Open
falsedrow opened this issue Dec 4, 2023 · 1 comment
Open

Comments

@falsedrow
Copy link

Py includes four types of wagons. For items, they are (1) 20 slots, six tiles long, one space between; (2) 20 slots, three tiles long, see image for the weird way inserters map to wagons; (3) 40 slots, six tiles long; (4) 40 slots, three tiles long, same as #2.

image

The layout code has things like "length = length - 7" in it that assume the vanilla wagon size, so I have to disable automatic allow-listing to use the compact trains.

I haven't looked yet at how the compact trains are implemented to figure out how to detect their layout. It's not obvious how to connect with the auto-allow-list code because a station can accept both 1-4 basic trains and 1-8 advanced trains.

@jagoly
Copy link
Contributor

jagoly commented Dec 6, 2023

I looked into this a while ago and the way that the layout code works currently makes this A LOT of work to implement. Everything is hardcoded, and even the way that train layout is stored assumes that every wagon and locomotive is the same length. The py wagons in particular overlapping a bit makes things even worse since there are now tiles that line up with more than wagon.

I might decide to have another look into it at some point but it's not high priority for me at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants