Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android nothing happens on click #60

Open
AdamGold opened this issue Dec 29, 2018 · 1 comment · May be fixed by #62
Open

Android nothing happens on click #60

AdamGold opened this issue Dec 29, 2018 · 1 comment · May be fixed by #62

Comments

@AdamGold
Copy link

AdamGold commented Dec 29, 2018 •
edited
Loading

iOS works fine. On Android, I can see the image being rendered, but nothing happens on click (no dialog opening).

<PhotoUpload
    onPhotoSelect={photo => {
        this.setState({ photo: photo });
    }}
    onStart={this.handleLoading}
    onRender={this.handleLoading}
>
    <Image
        style={styles.photo}
        resizeMode="cover"
        source={{
            uri:
                "https://www.sparklabs.com/forum/styles/comboot/theme/images/default_avatar.jpg"
        }}
    />
</PhotoUpload>
@AdamGold
Copy link
Author

This issue was with the default styling of the component. If you are having the same issue - go to index.js (inside react-native-photo-upload") and entirely delete the default styles.container (or change it so it works).

AdamGold added a commit to AdamGold/react-native-photo-upload that referenced this issue Jan 2, 2019
@AdamGold
# If applied, this commit will...
9aa5392 
delete container unnecessary styles to fix android bug where nothing happens on click.
# Provide links to any relevant tickets, articles or other resources
Closes: malsapp#60
Progresses : #
@AdamGold AdamGold linked a pull request Jan 2, 2019 that will close this issue
Open
AdamGold added a commit to AdamGold/react-native-photo-upload that referenced this issue Jan 6, 2019
@AdamGold
delete container unnecessary styles to fix android bug where nothing …
e701cc5 
…happens on click.

Closes: malsapp#60
Progresses : #
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Android where nothing happens on click AdamGold/react-native-photo-upload
1 participant
@AdamGold