Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple input arrays from Slack payload format #58

Open
maknz opened this issue Jun 26, 2016 · 0 comments
Open

Decouple input arrays from Slack payload format #58

maknz opened this issue Jun 26, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@maknz
Copy link
Owner

maknz commented Jun 26, 2016

At the time, having the input arrays into Attachment and friends be exactly the same as the Slack payload format was good, but now it's a hinderance when we want to be smarter about a few things, e.g. using timestamp rather than ts and a DateTime rather than an int UNIX timestamp.

It's made testing very difficult as a result, so I'll figure out a different way to do the functional tests, other than "these two arrays must match exactly" which is a huge PITA. It'll probably be inspecting each element individually, more verbose but no headaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant