-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amfora themeing updates #149
Comments
@sergetymo @bnthor @Skraylet @crdpa @lokesh-krishna You have all contributed themes to Amfora. Please see the above message and subscribe to this thread if you'd like to keep your theme maintained as Amfora improves. Thanks! |
For example, v1.7.0 is about to be released. It changes I am wary of changing your themes myself, so if you're interested it'd be appreciated if you made PRs to update them. Thanks! And no worries if you aren't interested in maintaining. Feel free to let me know if you rather I made the updates instead. |
Unfortunately i'm not using that theme anymore (Dracula) so if you could update it would be fine. The preformatted_text was already set in the original theme. I think the new values could just follow the pattern there: dl_modal_bg = "#282a36" |
@crdpa Okay, thanks for letting me know. I've updated the theme for the subscription modal using those values. This can be seen in d710085. I'll try and maintain the Dracula theme from now on, and you're welcome to take it back at any time by letting me know here. |
Thanks. I'll probably come back soon. Throwing an idea here. Wouldn't be better if amfora could do something like #include in it's config file? Users could alternate themes just changing one line at the config. |
Made required additions and changes in #153. |
@crdpa Hmm, an include key could be a good idea. Maybe like this: [theme]
include = "path/to/file.toml"
# Other keys will override the theme Or were you thinking the key could point to a network location? Edit: Let's discuss in #154 and not cloud this thread. |
This thread exists so that everyone who has created a theme for Amfora can know when they need to update it. When Amfora adds a new themeable object, like a new modal, it will be announced in this thread. Users who have created themes can subscribe to this thread, and update their themes accordingly.
The text was updated successfully, but these errors were encountered: