Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding -tags timetzdata to Go builds by default. #69

Open
jmalloc opened this issue Sep 24, 2021 · 0 comments
Open

Consider adding -tags timetzdata to Go builds by default. #69

jmalloc opened this issue Sep 24, 2021 · 0 comments
Labels
pkg:go Relates to the Go package

Comments

@jmalloc
Copy link
Contributor

jmalloc commented Sep 24, 2021

See https://pkg.go.dev/time/tzdata

Doing so removes Go's reliance on the system timezone database. I am in favour of this for two main reasons:

  • Removes the need to bake this timezone data into docker images (allowing for Go builds directly from scratch)
  • Potentially improves build repeatability, as the database moves in lockstep with the Go version

It does have a 450KB size penalty, which is considerable, so it should definitely be possible to turn this off with a makefile variable.

Alternatively, if there were some way we could force Go to avoid the system database such that you have to explicitly turn this option on to use any timezone data, that could also work.

@jmalloc jmalloc added the pkg:go Relates to the Go package label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:go Relates to the Go package
Development

No branches or pull requests

1 participant