Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting find command output in lib-core functions #11

Open
danilvpetrov opened this issue Oct 15, 2019 · 1 comment
Open

Sorting find command output in lib-core functions #11

danilvpetrov opened this issue Oct 15, 2019 · 1 comment
Labels
lib:core Relates to the core library

Comments

@danilvpetrov
Copy link
Contributor

In the following locations within lib-core functions the sorting of find command output is non-deterministic and can be OS-specific. Is there any chance the find command output could be piped to sort to expect a predictable order of files?
@jmalloc jmalloc added the lib:core Relates to the core library label Oct 15, 2019
@jmalloc
Copy link
Contributor

jmalloc commented Oct 15, 2019

For the record, we need this for the cases where the "find" scripts are used to produce a file in the GENERATED_FILES list. These need to be deterministic, as they are checked for correctness by the ci target.

ezzatron pushed a commit that referenced this issue Aug 23, 2021
@jmalloc
Merge pull request #11 from make-files/37-unconditional-use-of-genera…
1c86979 
…ted-files

Remove non-operational sercondary expansion of `GENERATED_FILES`.
ezzatron pushed a commit that referenced this issue Aug 23, 2021
@jmalloc
Merge pull request #11 from na4ma4/v1
7053c1d 
added install-protoc command from lib-gha to pkg-protobuf(v1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lib:core Relates to the core library
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmalloc @danilvpetrov