Mai Post Grid -- testimonial categories not displaying/saving

[shay328]

As of today, using the Mai Post Grid block, the testimonial post type stopped displaying/saving the taxonomy by term.

https://dev.meaganwilliamson.com/contact/

[JiveDig]

Do you get an error or anything when you try to save?

So the taxonomy and terms are available to set but it won’t save and therefore won’t display?

[shay328]

No error. it seems like i'm grabbing the terms, but the front end only ever displays all categories.

Side note, I think we need a byline parameter for testimonials. I don't know if I brought that up yet.

*edit: also are sliders available for the grid block?

[JiveDig]

This is def a bug. I can reproduce. Fixing now.

[JiveDig]

Argh front end fixed but still doesn't load correct taxos in backend.

[JiveDig]

Update for myself...

mai_get_acf_request( 'post_type' ) is not returning the saved post type in mai_get_post_type_taxonomy_choices() function. WTH.

[JiveDig]

This came up again somehow, I think since 2.35.0.

[JiveDig]

Making a note that this now only seems to happen when the block is saved while in Edit mode. v2.35.0 limits most of our queries to only happen when doing ajax, but in Edit mode it's on page load.

The fix is to add acf/prepare_field filter for every field we're doing heavy queries, and only load the option that is the current $field['value']. This is a light query on page load, and uses the full query once the user clicks the field to initiate the ajax loading.