Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use acf/is_field_key to validate our non-field_ keys #651

Open
JiveDig opened this issue Jul 11, 2024 · 0 comments
Open

Use acf/is_field_key to validate our non-field_ keys #651

JiveDig opened this issue Jul 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JiveDig
Copy link
Contributor

JiveDig commented Jul 11, 2024

After a discussion Liam from WPE/ACF, i found out that we wrongly register fields with keys that do not start with field_, which could potentially cause performance and other issues.

Elliot mentioned this requirement back in 2013 (https://support.advancedcustomfields.com/forums/topic/creating-theme-fields-generating-a-key/#post-6663), but somehow we missed it.

It wasn't really an issue until ACF 6.3.x when block validation stuff was added.

@JiveDig JiveDig added the bug Something isn't working label Jul 11, 2024
JiveDig added a commit that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant