Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parent/ancestor elements/classes/ids to skip for in-content CCAs #10

Open
JiveDig opened this issue Dec 6, 2022 · 1 comment
Open

Allow parent/ancestor elements/classes/ids to skip for in-content CCAs #10

JiveDig opened this issue Dec 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@JiveDig
Copy link
Contributor

JiveDig commented Dec 6, 2022 •
edited
Loading

Not sure how this would work, but say a website has a section element or div with a custom-class and we don't ever want a CCA to show inside that element. Before showing/counting, it could check if any ancestor matches. A bit of extra logic/processing, but would probably be worth it.

These elements would be available to add via a filter, and empty by default, so there wouldn't be any performance implications until the filter is used.
@JiveDig JiveDig added the enhancement New feature or request label Dec 6, 2022
@JiveDig
Copy link
Contributor Author

JiveDig commented Dec 7, 2022

Examples where this would benefit:

  • Never show an in-content CCA inside of a Group block
  • Never show an in-content CCA inside of a Recipe
  • etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JiveDig