-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels/aria tags to UI elements #2086
Comments
Thanks for your request! I think we have a lot todo with that. Can you also write a short "roadmap" which panels/paged would be the most important we should begin? I think we will need multiple steps to implement/fix something like that and we cannot do this in 1 step. |
I sincerely apologize for not providing one earlier; your request makes complete sense. |
This absolutely needs addressed--why some elements display tooltips while others do not is sloppy and not acceptable for software this mature. Every element on the page that controls the software should have a tooltip. |
At first... We all do this in our free time and nobody get payed for it. So if you think you have to be aggressive and post down votes, feel free to implement it yourself in your free time for free! Too many tool tips will also break the UX and tool tips itself have nothing Todo with this FR. Tooltips are not for screen readers! |
I agree with meteyou... no need to get angry. We're doing this in our free time and don't get any money for that. Even if mainsail is pretty mature right now. Most of the crew probably has little to no expierience with screen readers. At least I don't have any. @hidwood Do you think you would be able to test changes when we provide you a preview build? |
@lnorton89 Did you pay for Mainsail? If yes -> you were scammed. |
@rackrick and @meteyou I would be open to testing and evaluating any changes, I really do appreciate how seriously this is being taken and would be happy to assist in any way I can. |
Requested feature:
The UI should be updated with tags that give assistive technology, such as screen readers and magnifiers, understandable and focusable content that is reflective of the page. Aria(Accessible Rich Internet Applications) labels can be used for this purpose rather than adding traditional labels, as they would most likely interrupt the UI design and add extra clutter. This would allow for a much easier user experience for those that require such assistive technology, as well as better conforming to web content accessibility guidelines. Aria Live regions can also be used to alert users of assistive technology of notifications and important events, such as a component needing updated in the update manager or Klipper shutting down due to an issue.
Solves the following problem:
When navigating Mainsail, many elements are completely unlabeled for screen-reader users. This includes many buttons on the dashboard, many of which are not clearly obvious to a screen reader user as to their function, with others obviously belonging to increment and decrement buttons on various fields. Every page, notably the connect printer dialogues and macro screens, have several buttons whose purpose is unclear. There are likely many more examples but given that it is not necessarily feasible to run mainsail as a screen reader user now, they have not all been catalogued, however it may be noted that almost every button, barring the send button in the console, lack labeling.
Additional information:
Official vue.js accessibility page:
https://vuejs.org/guide/best-practices/accessibility
The Web content Accessibility Guidelines:
https://www.w3.org/TR/WCAG21/
https://www.w3.org/TR/wai-aria-1.2/
https://www.w3.org/WAI/ARIA/apg/
Examples of screen readers, magnifiers, and other automated tooling is available on the vue.js page linked above.
I am not a particularly skilled frontend web developer, and thus have relatively little idea how much effort this may take, however I fear that it may be significant. I would be glad to help in any way to rectify this, as, being a completely blind maker, having another option other than OctoPrint that can talk to Klipper would be fantastic, especially one as capable as Mainsail.
The text was updated successfully, but these errors were encountered: