-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added second layer confirmation for Cancel Job #1978
Conversation
Language file analysis report:
|
Language file analysis report:
|
2 similar comments
Language file analysis report:
|
Language file analysis report:
|
Thx for your PR! its fine, that you only add languages, which you are know/speak. all other languages should be translated by the translators. (missing translations are better then wrong translations, because the translators will find them faster). you don't need docker for testing it. you just have to:
then you should be able to test it. please change the toolbar from red to normal. the e-stop dialog is the only one that has this toolbar color. every other confirm dialog does not have this. furthermore, i am still thinking about how useful this dialog is, because it is actually a third level confirm (pause -> cancel -> dialog). but it is optional, and there are users who deactivate the pause -> cancel, so it could be useful especially for these users. |
Language file analysis report:
|
Language file analysis report:
|
pls also change the icon from the dialog. this one looks like a "loading issue" from the icon. |
Language file analysis report:
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Description
This PR adds a second layer confirmation dialog for the Cancel Job button.
Related Tickets & Documents
None.
Mobile & Desktop Screenshots/Recordings