Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-Code tab suggestions ignore primary color setting #1730

Closed
wlhlm opened this issue Jan 4, 2024 · 2 comments · Fixed by #1733
Closed

G-Code tab suggestions ignore primary color setting #1730

wlhlm opened this issue Jan 4, 2024 · 2 comments · Fixed by #1733
Labels
⚡ Type: Bug Something isn't working

Comments

@wlhlm
Copy link

wlhlm commented Jan 4, 2024

Mainsail Version:

2.9.1

Browser:

Firefox

Device:

Desktop PC

Operating System:

Windows

What happened?

G-Code tab suggestions appear blue in terminal instead of red which is my primary color in the Mainsail UI settings.

mainsail-tab-color

What did you expect to happen instead?

G-Codes suggested when hitting tab to complete the current command line should appear in primary color in the terminal.

How to reproduce this bug?

Go to the G-Code console, type SET_, hit the tab key, Mainsail then suggests a number of G-Codes with the SET_ prefix for completion.

Additional information:

No response

@wlhlm wlhlm added the ⚡ Type: Bug Something isn't working label Jan 4, 2024
@meteyou
Copy link
Member

meteyou commented Jan 4, 2024

Yes. This is hardcoded to blue and have nothing Todo with primary color.

@wlhlm
Copy link
Author

wlhlm commented Jan 4, 2024

I see. Though I don't understand why it would need to be hardcoded and ignore the UI color setting. The tab suggestions seem to work the same way as for example G-Codes put into the console through other means (such as pressing movement buttons), namely clicking on them puts them into console input field.

My workaround for now is the following snippet in my theme CSS:

/* See https://github.com/mainsail-crew/mainsail/issues/1730 */
a.command.blue--text {
    color: var(--v-anchor-base) !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants