Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image build on automated "tag" push not executed #1721

Closed
chrisbraucker opened this issue Dec 28, 2023 · 1 comment · Fixed by #1723
Closed

Docker image build on automated "tag" push not executed #1721

chrisbraucker opened this issue Dec 28, 2023 · 1 comment · Fixed by #1723
Labels
⚡ Type: Bug Something isn't working

Comments

@chrisbraucker
Copy link

Mainsail Version:

2.5.0 - current

Browser:

Other (Please tell us below)

Device:

Other (Please tell us below)

Operating System:

Other (Please tell us below)

What happened?

As of now, when a git tag is pushed through an action, it does not trigger the action in .github/workflows/publish_docker.yml, so no version-tagged images are released.
From GitHub's side, this is expected, like https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow documents.

What did you expect to happen instead?

For every release version there should be a matching docker image available.

How to reproduce this bug?

As stated above, using the GITHUB_TOKEN when pushing tags does not start actions that trigger on tag push.

Additional information:

I've yet to fix this in my fork and am not entirely sure where the Personal Access Token should be used.

@chrisbraucker chrisbraucker added the ⚡ Type: Bug Something isn't working label Dec 28, 2023
@meteyou
Copy link
Member

meteyou commented Dec 30, 2023

thx for your report. I'm right now checking the issue, the workflow itself, will be triggered, but there is an issue with the tags... i have to look at it deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants