Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console error and unexpected hover graph behavior in 2.9.0 #1709

Closed
blonestar opened this issue Dec 23, 2023 · 2 comments · Fixed by #1706
Closed

Console error and unexpected hover graph behavior in 2.9.0 #1709

blonestar opened this issue Dec 23, 2023 · 2 comments · Fixed by #1706
Labels
⚡ Type: Bug Something isn't working
Milestone
v2.9.1

Comments

@blonestar
Copy link

Mainsail Version:

2.9.0

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

On graph hover it throws console error and it does not show box with temperatures.
image

What did you expect to happen instead?

It should show box with information's on graph hover.

How to reproduce this bug?

Just update Mainsail to 2.9.0
2.8.0 works fine, I was downgrade it to check.

Additional information:

No response
@blonestar blonestar added the ⚡ Type: Bug Something isn't working label Dec 23, 2023
@blonestar blonestar changed the title Console error and unexpected hover graph behavior Console error and unexpected hover graph behavior in 2.9.0 Dec 23, 2023
@blonestar
Copy link
Author

I guess it is a duplicate of
#1655

@meteyou
Copy link
Member

meteyou commented Dec 24, 2023

Thx for posting this issue. This bug has nothing todo with #1655. This bug comes with the light mode PR: #1580 .

i Fixed this PR already here: #1706 . I hope i can merge it as soon as possible and release a bugfix release.

@meteyou meteyou mentioned this issue Dec 24, 2023
Merged
@meteyou meteyou linked a pull request Dec 24, 2023 that will close this issue
fix: fix theme issue in tempchart #1706
Merged
@meteyou meteyou added this to the v2.9.1 milestone Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Milestone
v2.9.1
Development

Successfully merging a pull request may close this issue.

fix: fix theme issue in tempchart meteyou/mainsail-dev
2 participants
@blonestar @meteyou