UI move buttons may not restore absolute coordinates.

[fjpanag]

Mainsail Version:

v2.8.0

Browser:

Firefox

Device:

Desktop PC

Operating System:

Linux

What happened?

When I press a move button, it send the following sequence of commands to the printer:

G91
G1 X+10 F6000
G90

If however the requested movement is not possible (for example the printhead is near its travel limit), the following is generated:

G91
G1 X-100 F6000
Move out of range: -15.000 220.000 8.899 [0.000]

A G90 is never sent, and spuriously leaves the printer in relative coordinates.
This is definitely confusing, and has the great potential to cause a crash.

What did you expect to happen instead?

A G90 should always be sent, regardless of the result of the movement.

How to reproduce this bug?

Home the printer and set the printhead somewhere close to the travel limit.
Press a movement button that would cause a move outside the travel limit.

For example:

1. G90
2. G1 X10
3. Press the button for a 100mm left movement of the printhead.
4. Observe the terminal; no G90 is issued.

Additional information:

No response

[meteyou]

It was send, only Klipper doesnt execute it, because the command before exit the current gcode block.