feat: add minimum_cruise_ratio support in MotionSettingsPanel #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
|
Language file analysis report:
|
dw-0
approved these changes
Dec 8, 2023
4rnoP
pushed a commit
to 4rnoP/mainsail
that referenced
this pull request
Dec 13, 2023
4rnoP
pushed a commit
to 4rnoP/mainsail
that referenced
this pull request
Dec 13, 2023
|
Just a little thought from UX perspective. As this value now is a ratio. Wouldn’t it make sense to expose this as a percentage? So not 0.5 but 50%? Greets, |
|
@b00gie-dev, thanks for this idea. It sounds reasonable to me. Pls create a new FR in the issue tracker, so that I don't forget it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switch from
max_accel_to_deceltominimum_cruise_ratio. The old field will be used as fallback, if nominimum_cruise_ratioexists.Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?
Klipper PR for this feature: Klipper3d/klipper#6418