Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing instruction to add in the manual setup guide #1664

Closed
ZakVilneuv opened this issue Nov 24, 2023 · 1 comment
Closed

Missing instruction to add in the manual setup guide #1664

ZakVilneuv opened this issue Nov 24, 2023 · 1 comment
Labels
⚡ Type: Bug Something isn't working
Milestone

Comments

@ZakVilneuv
Copy link

Mainsail Version:

v2.8.0

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

Not a real issue with mainsail, but a missing instruction to add to the manual setup guide, causing an error, and a non accessible mainsail web interface
On this page : https://docs.mainsail.xyz/setup/getting-started/manual-setup

What did you expect to happen instead?

When installing Mainsail web server & proxy.
At the point : sudo nano /etc/nginx/sites-available/mainsail

You should add, as in other parts of this page :

Please check and modify the username!
If you do not use the user pi, you must replace it in each path and in the variable User in the service file.

because there is a section in the file with the normal "pi" in a path :

web_path from mainsail static files

root /home/pi/mainsail;

I had payed attention everywhere but not in this place (il was late in the night), and had to do double-check the whole setup to find my mistake. With this added instruction in this point, every noobs would have success with manual setup.

P.S. : I had to do manual setup because I'm using a Klipper fork for my touchscreen machine.

How to reproduce this bug?

not a bug, just an instruction to add in the manual setup guide page

Additional information:

With adding this missing advice at this precise point, the instructions page would be perfect, and complete !
Thank's again for the job done by the team !

@ZakVilneuv ZakVilneuv added the ⚡ Type: Bug Something isn't working label Nov 24, 2023
@meteyou meteyou added this to the vNext milestone Nov 24, 2023
@meteyou
Copy link
Member

meteyou commented Dec 3, 2023

Thx! I added a warnings block in the manual setup guide.

@meteyou meteyou closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants