-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case light toggle in webcam widget headers #1654
Comments
thank you for your feature request! something like this has already been requested several times (but mostly with the option in the title bar). how would you assign the right light to this button? |
@meteyou would suggest adding a field to the webcam settings referencing the output pin name/id in printer.cfg. Example: |
Output pin is the old variant... Today, led or neopixel is more recommended for caselight. |
Ah right, screenshot is from default Voron Trident config I am running. Will update. Given the better modern config entities, maybe a good solution would rather be a drop-down in the webcam settings view with all configured leds? |
If you're going through with this, I'd much prefer allowing any macro here instead of directly taking klipper's leds. A lot of lights go through Moonraker's integrations and not through klipper itself for various reasons (WLED niceties, too many leds, etc.). Even within klipper, you may want multiple lights to turn on, only turn it on to XX% power, or apply an led template, and that sounds very complicated to handle within mainsail but very easy to leave up to a macro. For those that have the simple case and use klipper's built in support for leds, it's not hard to write a macro that just does SET_LED, and having a simple 'LIGHTS_ON/OFF' macro benefits other places like klipperscreen. Alternatively, you can let the macro in mainsail take parameters and default to something like 'SET_LED LED=lights WHITE={brightness}' |
Sounds like a great suggestion @jmerdich |
Requested feature:
It would be fantastic to have a on/off toggle for printer leds in the webcam widget header. I don't want to leave lights on constantly, checking in on the print via webcam from the phone it would be super conventient to toggle the light on and off right there. Would suggest design similar to the print pause button.
Something like this, but cleaner design ofc :)
Solves the following problem:
No response
Additional information:
No response
The text was updated successfully, but these errors were encountered: