Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case light toggle in webcam widget headers #1654

Open
onsimon opened this issue Nov 14, 2023 · 7 comments
Open

Case light toggle in webcam widget headers #1654

onsimon opened this issue Nov 14, 2023 · 7 comments
Labels
💡 Type: FR Requests a new feature

Comments

@onsimon
Copy link

onsimon commented Nov 14, 2023

Requested feature:

It would be fantastic to have a on/off toggle for printer leds in the webcam widget header. I don't want to leave lights on constantly, checking in on the print via webcam from the phone it would be super conventient to toggle the light on and off right there. Would suggest design similar to the print pause button.

Something like this, but cleaner design ofc :)

mainsail-light-toggle

Solves the following problem:

No response

Additional information:

No response

@onsimon onsimon added the 💡 Type: FR Requests a new feature label Nov 14, 2023
@meteyou
Copy link
Member

meteyou commented Nov 14, 2023

thank you for your feature request! something like this has already been requested several times (but mostly with the option in the title bar).

how would you assign the right light to this button?

@onsimon
Copy link
Author

onsimon commented Nov 15, 2023

@meteyou would suggest adding a field to the webcam settings referencing the output pin name/id in printer.cfg. Example:

mainsail-webcam-light-config

@onsimon
Copy link
Author

onsimon commented Nov 15, 2023

Alternative button placement could be overlay on the webcam image, ideally with configurable corner in that case. This would enable individual control when showing multiple webcams. But, I think the title bar is nicer and in multi-view it could toggle all configured lights for the shown cams.

mainsail-light-toggle-overlay

@meteyou
Copy link
Member

meteyou commented Nov 15, 2023

Output pin is the old variant... Today, led or neopixel is more recommended for caselight.

@onsimon
Copy link
Author

onsimon commented Nov 15, 2023

Ah right, screenshot is from default Voron Trident config I am running. Will update.

Given the better modern config entities, maybe a good solution would rather be a drop-down in the webcam settings view with all configured leds?

https://www.klipper3d.org/Config_Reference.html#leds

@jmerdich
Copy link

If you're going through with this, I'd much prefer allowing any macro here instead of directly taking klipper's leds. A lot of lights go through Moonraker's integrations and not through klipper itself for various reasons (WLED niceties, too many leds, etc.). Even within klipper, you may want multiple lights to turn on, only turn it on to XX% power, or apply an led template, and that sounds very complicated to handle within mainsail but very easy to leave up to a macro.

For those that have the simple case and use klipper's built in support for leds, it's not hard to write a macro that just does SET_LED, and having a simple 'LIGHTS_ON/OFF' macro benefits other places like klipperscreen. Alternatively, you can let the macro in mainsail take parameters and default to something like 'SET_LED LED=lights WHITE={brightness}'

@onsimon
Copy link
Author

onsimon commented Feb 17, 2024

Sounds like a great suggestion @jmerdich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Type: FR Requests a new feature
Projects
None yet
Development

No branches or pull requests

3 participants