Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved toolhead selector buttons #1564

Closed
wants to merge 7 commits into from
Closed

feat: Improved toolhead selector buttons #1564

wants to merge 7 commits into from

Conversation

HelgeKeck
Copy link

@HelgeKeck HelgeKeck commented Sep 20, 2023

Description

Improved toolhead selector buttons

Signed-off-by: Helge Keck [email protected]

Related Tickets & Documents

fixes: #1272

Mobile & Desktop Screenshots/Recordings

https://discord.com/channels/758059413700345988/901024829875027998/1154081960176648242

[optional] Are there any post-deployment tasks we need to perform?

@HelgeKeck HelgeKeck changed the title Improved toolhead selector buttons feat: Improved toolhead selector buttons Sep 20, 2023
@HelgeKeck
Copy link
Author

having problems to wrap the t buttons into multiple lines

@meteyou
Copy link
Member

meteyou commented Sep 20, 2023

thx! i will check this PR asap. i think we have to convert the array of tools in a 2 dimension array. Dimension 1 -> row, dimension 2 -> tools.

@HelgeKeck
Copy link
Author

image

@HelgeKeck
Copy link
Author

image
image

@meteyou
Copy link
Member

meteyou commented Sep 22, 2023

looks really nice! I don't know if it is needed to change the name/title...

I hope one of the crew has time to review my PR, then we have to update this PR from develop to move this code in the separate SFC.

@HelgeKeck
Copy link
Author

image

@meteyou
Copy link
Member

meteyou commented Sep 22, 2023

i think the "active" background color is enough. furthermore, the wrap does not work any more with custom titles, because you do not know what the customer writes in. "printing" is much longer than Tx.

@meteyou
Copy link
Member

meteyou commented Sep 23, 2023

refactoring PR is merged. pls update your branch from develop: #1565

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys

@HelgeKeck
Copy link
Author

i am sure there is a better vue way to do that. but it works so far

@HelgeKeck HelgeKeck closed this Oct 1, 2023
@HelgeKeck HelgeKeck deleted the improved-toolhead-selector-buttons branch October 1, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redesign tool colors in extruder panel
2 participants