-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved toolhead selector buttons #1564
feat: Improved toolhead selector buttons #1564
Conversation
mainsail merge
fix: fix type issue in TemperaturePanelListItem (#1563)
having problems to wrap the t buttons into multiple lines |
thx! i will check this PR asap. i think we have to convert the array of tools in a 2 dimension array. Dimension 1 -> row, dimension 2 -> tools. |
looks really nice! I don't know if it is needed to change the name/title... I hope one of the crew has time to review my PR, then we have to update this PR from develop to move this code in the separate SFC. |
i think the "active" background color is enough. furthermore, the wrap does not work any more with custom titles, because you do not know what the customer writes in. "printing" is much longer than Tx. |
refactoring PR is merged. pls update your branch from develop: #1565 |
Language file analysis report:
|
i am sure there is a better vue way to do that. but it works so far |
…nto mainsail-crew-develop
Description
Improved toolhead selector buttons
Signed-off-by: Helge Keck [email protected]
Related Tickets & Documents
fixes: #1272
Mobile & Desktop Screenshots/Recordings
https://discord.com/channels/758059413700345988/901024829875027998/1154081960176648242
[optional] Are there any post-deployment tasks we need to perform?