Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added features for disabled state, busy state. #1193

Closed
wants to merge 12 commits into from
Closed

fix: added features for disabled state, busy state. #1193

wants to merge 12 commits into from

Conversation

vajonam
Copy link
Contributor

@vajonam vajonam commented Dec 14, 2022

added features to get on par with other control schemes.

  • loading indicator for the axis being homed, disabled stepping during that
  • disabled with proper colors while printing
  • flashing indicator for loading. open to ideas on how to change this to spinner.
circle_contorl_enhancements.mp4

@meteyou
Copy link
Member

meteyou commented Feb 18, 2023

Please clean up your CSS code. it's not useful to add every id to the selectors.

@vajonam
Copy link
Contributor Author

vajonam commented Feb 18, 2023

I will see if can simplify this.

@meteyou
Copy link
Member

meteyou commented Jun 18, 2023

@vajonam any news here?

@vajonam
Copy link
Contributor Author

vajonam commented Jun 19, 2023

@meteyou I can re-base and try to clean it up some, but sill will need help with simplifying CSS. I wasn't sure there was much interest in this feature, so really didn't keep to upto date. I will work on this week with an update.

@vajonam
Copy link
Contributor Author

vajonam commented Jun 19, 2023

I will re-open a new PR.

@vajonam vajonam closed this Jun 19, 2023
@meteyou
Copy link
Member

meteyou commented Jun 19, 2023

If you need help, feel free to ping me. Even if this feature is not a must-have, I see no problem merging it if the code fits.

@vajonam
Copy link
Contributor Author

vajonam commented Nov 12, 2023

Sorry I wont be submitting this PR. I have moved on from mainsail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants