From 45f3e5ab676af4f35db73adeccc7a9e48ef65af6 Mon Sep 17 00:00:00 2001
From: Stefan Dej <meteyou@gmail.com>
Date: Mon, 16 Sep 2024 01:01:54 +0200
Subject: [PATCH] refactor: extract some logic into a separate methods

Signed-off-by: Stefan Dej <meteyou@gmail.com>
---
 src/components/mixins/historyStats.ts | 30 +++++++++++++++------------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/src/components/mixins/historyStats.ts b/src/components/mixins/historyStats.ts
index 008fa7adb..831e79114 100644
--- a/src/components/mixins/historyStats.ts
+++ b/src/components/mixins/historyStats.ts
@@ -7,8 +7,6 @@ import {
 } from '@/store/server/history/types'
 import i18n from '@/plugins/i18n'
 
-type StatusKeys = 'completed' | 'in_progress' | 'cancelled' | 'default'
-
 @Component
 export default class HistoryStatsMixin extends Vue {
     valueName!: HistoryStatsValueNames
@@ -21,17 +19,27 @@ export default class HistoryStatsMixin extends Vue {
         return this.getChartData(this.$store.getters['server/history/getSelectedJobs'])
     }
 
-    private getChartData(jobs: ServerHistoryStateJob[]) {
-        const output: ServerHistoryStateAllPrintStatusEntry[] = []
-        const hidePrintStatus = this.$store.state.gui.view.history.hidePrintStatus ?? []
-
-        const colorMap: Record<StatusKeys, string> = {
+    private getStatusColor(status: string) {
+        const colorMap: Record<string, string> = {
             completed: '#BDBDBD',
             in_progress: '#EEEEEE',
             cancelled: '#616161',
             default: '#424242',
         }
 
+        return colorMap[status] ?? colorMap.default
+    }
+
+    private getLocalizedStatusName(status: string) {
+        return i18n.te(`History.StatusValues.${status}`, 'en')
+            ? i18n.t(`History.StatusValues.${status}`).toString()
+            : status
+    }
+
+    private getChartData(jobs: ServerHistoryStateJob[]) {
+        const output: ServerHistoryStateAllPrintStatusEntry[] = []
+        const hidePrintStatus = this.$store.state.gui.view.history.hidePrintStatus ?? []
+
         jobs.forEach((current: ServerHistoryStateJob) => {
             const index = output.findIndex((element) => element.name === current.status)
             if (index !== -1) {
@@ -41,19 +49,15 @@ export default class HistoryStatsMixin extends Vue {
                 return
             }
 
-            const displayName = i18n.te(`History.StatusValues.${current.status}`, 'en')
-                ? i18n.t(`History.StatusValues.${current.status}`).toString()
-                : current.status
-
             output.push({
                 name: current.status,
-                displayName,
+                displayName: this.getLocalizedStatusName(current.status),
                 value: 1,
                 valueFilament: current.filament_used,
                 valueTime: current.print_duration,
                 itemStyle: {
                     opacity: 0.9,
-                    color: colorMap[current.status as StatusKeys] ?? colorMap.default,
+                    color: this.getStatusColor(current.status),
                     borderColor: '#1E1E1E',
                     borderWidth: 2,
                     borderRadius: 3,