Indicate detected peak in waveform view

[acomrie]

Would it be possible to add a very light vertical line in the waveform view (especially the view that does not use the electrode geometry) to indicate the detected peak of the waveform?

This would help the user definitively identify the waveform peak for a given cluster, rather than trying to eyeball it, in a few cases - such as, when there is a double-peaked waveform, or when unequal numbers of points are displayed to the left and right of the detected peak and when the number points to left and right are not known by the user.

Thank you.

[magland]

@acomrie, the rendering part should be easy to implement... however we'll need to clarify it a some things first.

Do you envision putting the line on all of the channels at the t=0 position?

Or do you envision putting the line on only the channel with the peak? If so, we could detect that as the channel where the amplitude at t=0 is the highest. Not too hard. Keep in mind, this might not coincide with the peak channel identified by the algorithm. The visualization of sortingview is alg agnostic.

Do you want the line to be at t=0 (where the event is marked), or do you want it at the actual peak? These will probably agree most of the time, but not guaranteed. I think the former is better.

My feeling at this point is that we should put a very dim line at t=0 for all the channels, and then have a somewhat darker line on the channel where the amplitude at t=0 is highest. What do you think?

[acomrie]

Hi @magland, I was simply envisioning a dim line across all channels at t=0. I think that would be enough on its own. Having a darker line on the channel where the amplitude at t=0 is highest seems like it would be fine too, but I'm not sure what the cases are for which that would be more useful than simply the line across all chans at t=0. Also not clear to me how a darker line on the channel where the amplitude is highest would interact with zooming in and out. So, I'd lean towards the simplest and least-busy-looking solution at this point I think.

[magland]

Okay, that's the easiest to implement. 👌