Error when setting default levels

[peniblec]

Heya!

Been observing this on a couple of setups these past few days; reproduced with magit, rg, and transient-showcase, after some rounds of package-reinstall and package-recompile so starting to believe this is not a franken-version problem and finally worked up the nerve to bother you with this.

tl;dr C-x l once to display levels, C-x l a second time to change the default level, and this shows up in *Messages*:

Error in pre-command-hook (transient--pre-command): (error "BUG: Cannot determine suffix object")
let: Wrong type argument: (or eieio-object cl-structure-object oclosure), nil

Backtrace with toggle-debug-on-error:

Debugger entered--Lisp error: (error "BUG: Cannot determine suffix object")
  apply(debug (error (error "BUG: Cannot determine suffix object")))
  transient--exit-and-debug(error (error "BUG: Cannot determine suffix object"))
  error("BUG: Cannot determine suffix object")
  (if command (car suffixes) (error "BUG: Cannot determine suffix object"))
  (or (if (cdr suffixes) (cl-find-if #'(lambda (obj) (equal (listify-key-sequence (transient--kbd (eieio-oref obj 'key))) (listify-key-sequence (this-command-keys)))) suffixes) (car suffixes)) (if command (car suffixes) (error "BUG: Cannot determine suffix object")))
  (let ((suffixes (cl-remove-if-not #'(lambda (obj) (eq (eieio-oref obj 'command) (or command (if (eq this-command 'transient-set-level) this-original-command this-command)))) (or transient--suffixes transient-current-suffixes)))) (or (if (cdr suffixes) (cl-find-if #'(lambda (obj) (equal (listify-key-sequence (transient--kbd (eieio-oref obj 'key))) (listify-key-sequence (this-command-keys)))) suffixes) (car suffixes)) (if command (car suffixes) (error "BUG: Cannot determine suffix object"))))
  (cond (transient--pending-suffix) ((or transient--prefix transient-current-prefix) (let ((suffixes (cl-remove-if-not #'(lambda (obj) (eq (eieio-oref obj 'command) (or command (if (eq this-command 'transient-set-level) this-original-command this-command)))) (or transient--suffixes transient-current-suffixes)))) (or (if (cdr suffixes) (cl-find-if #'(lambda (obj) (equal (listify-key-sequence (transient--kbd (eieio-oref obj 'key))) (listify-key-sequence (this-command-keys)))) suffixes) (car suffixes)) (if command (car suffixes) (error "BUG: Cannot determine suffix object"))))) ((let* ((obj (and t (transient--suffix-prototype (or command this-command)))) (obj (and obj (clone obj)))) (if obj (progn (progn (transient-init-scope obj) (transient-init-value obj) obj))))))
  transient-suffix-object()
  (and transient--editp (transient-suffix-object) (not (memq this-command '(transient-quit-one transient-quit-all transient-help))))
  (cond ((memq this-command '(transient-update transient-quit-seq)) (transient--pop-keymap 'transient--redisplay-map)) ((and transient--helpp (not (memq this-command '(transient-quit-one transient-quit-all)))) (cond ((transient-help) (transient--do-suspend) (setq this-command 'transient-suspend) (transient--pre-exit)) ((not (transient--edebug-command-p)) (setq this-command 'transient-undefined)))) ((and transient--editp (transient-suffix-object) (not (memq this-command '(transient-quit-one transient-quit-all transient-help)))) (setq this-command 'transient-set-level) (transient--wrap-command)) (t (setq transient--exitp nil) (let ((exitp (eq (transient--call-pre-command) transient--exit))) (transient--wrap-command) (if exitp (progn (transient--pre-exit))))))
  (progn (if (and (transient--get-pre-command this-original-command 'suffix) (not (transient--get-pre-command this-command 'suffix))) (progn (setq this-command this-original-command))) (cond ((memq this-command '(transient-update transient-quit-seq)) (transient--pop-keymap 'transient--redisplay-map)) ((and transient--helpp (not (memq this-command '(transient-quit-one transient-quit-all)))) (cond ((transient-help) (transient--do-suspend) (setq this-command 'transient-suspend) (transient--pre-exit)) ((not (transient--edebug-command-p)) (setq this-command 'transient-undefined)))) ((and transient--editp (transient-suffix-object) (not (memq this-command '(transient-quit-one transient-quit-all transient-help)))) (setq this-command 'transient-set-level) (transient--wrap-command)) (t (setq transient--exitp nil) (let ((exitp (eq (transient--call-pre-command) transient--exit))) (transient--wrap-command) (if exitp (progn (transient--pre-exit)))))))
  (let ((debugger #'transient--exit-and-debug)) (progn (if (and (transient--get-pre-command this-original-command 'suffix) (not (transient--get-pre-command this-command 'suffix))) (progn (setq this-command this-original-command))) (cond ((memq this-command '(transient-update transient-quit-seq)) (transient--pop-keymap 'transient--redisplay-map)) ((and transient--helpp (not (memq this-command '(transient-quit-one transient-quit-all)))) (cond ((transient-help) (transient--do-suspend) (setq this-command 'transient-suspend) (transient--pre-exit)) ((not (transient--edebug-command-p)) (setq this-command 'transient-undefined)))) ((and transient--editp (transient-suffix-object) (not (memq this-command '(transient-quit-one transient-quit-all transient-help)))) (setq this-command 'transient-set-level) (transient--wrap-command)) (t (setq transient--exitp nil) (let ((exitp (eq (transient--call-pre-command) transient--exit))) (transient--wrap-command) (if exitp (progn (transient--pre-exit))))))))
  (condition-case err (let ((debugger #'transient--exit-and-debug)) (progn (if (and (transient--get-pre-command this-original-command 'suffix) (not (transient--get-pre-command this-command 'suffix))) (progn (setq this-command this-original-command))) (cond ((memq this-command '(transient-update transient-quit-seq)) (transient--pop-keymap 'transient--redisplay-map)) ((and transient--helpp (not (memq this-command '(transient-quit-one transient-quit-all)))) (cond ((transient-help) (transient--do-suspend) (setq this-command 'transient-suspend) (transient--pre-exit)) ((not (transient--edebug-command-p)) (setq this-command 'transient-undefined)))) ((and transient--editp (transient-suffix-object) (not (memq this-command '(transient-quit-one transient-quit-all transient-help)))) (setq this-command 'transient-set-level) (transient--wrap-command)) (t (setq transient--exitp nil) (let ((exitp (eq (transient--call-pre-command) transient--exit))) (transient--wrap-command) (if exitp (progn (transient--pre-exit)))))))) ((debug error) (transient--emergency-exit :pre-command) (signal (car err) (cdr err))))
  transient--pre-command()

Still not 100% sure this is a genuine bug, vs a package installation SNAFU. Figure I'll open a discussion first; if no-one can reproduce, it'll definitely point to the latter?

---

emacs-version
    GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2) of 2024-11-29
emacs-repository-version
    2024-11-29 "New function `completion-list-candidate-at-point'" (eec1a68b009)
C-h P transient
     Status: Installed in ‘transient-20241206.2204/’,
             shadowing a built-in package (unsigned).
    Version: 20241206.2204
     Commit: 005e50bf4683cbb58b5c48c873609e7f4af7ac5f

PS: congrats on the latest releases 🙇

[tarsius]

finally worked up the nerve to bother you with this.

Well, this is triggered by a change that I knew might cause breakage, and I did it precisely because I wanted to learn about when that happens. (Of course I wasn't sure it would happen, if that were the case, there wouldn't have been any need to resort to this approach. In other words, I was waiting for your report. 😁

Some more details in dd69194.

[peniblec]

In other words, I was waiting for your report. 😁

Oh, well apologies for my tardiness then 😀

Some more details in dd69194.

Fetched & evaled, and rg & magit now both accept saving levels 🎉 Thanks a lot!