Skip to content
This repository has been archived by the owner on Oct 26, 2020. It is now read-only.

KerbalKonstructs for KSP 1.4 will break KTC integration. #175

Open
GER-Space opened this issue Mar 9, 2018 · 2 comments
Open

KerbalKonstructs for KSP 1.4 will break KTC integration. #175

GER-Space opened this issue Mar 9, 2018 · 2 comments

Comments

@GER-Space
Copy link

Hi magico13,

I have to make a sad announcement, but for compatibility with KSP1.4 I will have to rename the LaunchSite Class into KKLaunchSite, becasue KSP now has its own class.
But: You are only intrested in open LaunchSites and maybe you can get them through KSP directly, as soon I found a way to feed them into KSP without the expansion installed.

Do you want an PR with the changes, or will you make it by yourself?

@magico13
Copy link
Owner

magico13 commented Mar 9, 2018

I can just do it myself unless you already have a PR ready. And you shouldn't have to rename anything since they're in different namespaces, but you'd have to fully qualify any uses of LaunchSite to remove any ambiguity.

@GER-Space
Copy link
Author

With 1.4 you can get all Launchsites from (Stock ones, all DLC and hopefully KK with)

PsystemSetup.instance.LaunchSites

No need to use reflection to Kerbal Konstructs. I need to fill this list with all open launchsites, so I can launch vessel again. This all changed.

The open LS are that what you care about, right?
Using fully qualified named in my own code is a NoGo for me. Its ugly to read

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants