Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved service error details #28

Open
2 tasks done
smithki opened this issue Apr 21, 2020 · 1 comment
Open
2 tasks done

Improved service error details #28

smithki opened this issue Apr 21, 2020 · 1 comment
Assignees
@smithki
Labels
✨Feature Request 🔥 Priority 2 Medium priority bug/feature

Comments

@smithki
Copy link
Contributor

smithki commented Apr 21, 2020

✅ Prerequisites

  • Did you perform a cursory search of open issues? Is this feature already requested elsewhere?
  • Are you reporting to the correct repository (@magic-sdk/admin)?

✨ Feature Request

Improve error handling for external services. Currently, service errors manifest generically, but developers can benefit from more granular error types.

🧩 Context

None.

💻 Examples

None.
@smithki smithki self-assigned this Apr 21, 2020
@smithki smithki mentioned this issue Apr 21, 2020
Closed
@smithki smithki added the 🔥 Priority 2 Medium priority bug/feature label Apr 21, 2020
@michaelmerrill
Copy link

michaelmerrill commented Jan 24, 2021 •
edited
Loading

To expand on this, would it be possible to expose the MagicAdminSDKError class so that we can do an instanceof check when error handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smithki smithki

Labels
✨Feature Request 🔥 Priority 2 Medium priority bug/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelmerrill @smithki