Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a DH, I would like if the schedule (and related items) worked in non-30 minute increments. #3437

Open
DeastDX opened this issue Mar 4, 2019 · 2 comments

Comments

@DeastDX
Copy link

DeastDX commented Mar 4, 2019

We have had issues with this at MAGLabs for several years now, as we have been scheduling in 15 minute increments but then struggle to put that schedule into Uber. It was a moderate catastrophe this past year as the schedule was unable to go live until halfway through the first day of the event, which likely affected badge sales and definitely affected attendee happiness (probably the #1 complaint at Feedback).

I've had someone who is code-fluent look into this and they said to request it early in the year because it would be a large undertaking, but I feel like it is a very worthwhile task. They also mentioned that they thought the best way to change it would be to just change it to where any time increment could work. Just passing that along -shrug-.

The ability to schedule things not in half hour increments could benefit so many departments in so many ways and would allow us to create more intuitively timed programming for attendees. PLEASE make this happen!

@EliAndrewC
Copy link
Contributor

Thanks for filing this. I'll make sure that this is discussed this month during our 2019 prioritization meeting.

Unfortunately, the schedule code is basically the oldest code in our whole codebase, and was coded while I was in college... and it really shows :(

This particular limitation comes from the fact that I didn't code a start-time and end-time, but rather coded it as a start-time and then an integer number of hour-long increments. This was later modified to be half-hour increments, so changing it to 15-minute increments is... probably not all that terrible? Although the real solution would be to either store an end-time or a duration in a smaller increment like 1-minute so that we can make the lengths more arbitrary instead of having to hard-code things like 60-minutes or 30-minutes, or 15-minutes, etc.

This is a bigger deal than it should be because of how many places we encode this assumption. However, the fact that this remains so painful is a good sign that we should make this a priority if possible.

@DeastDX
Copy link
Author

DeastDX commented Mar 4, 2019

Aye, that's basically how it was described to me. The sheer size of the fix is why I was advised to ask for this super early in the year. Appreciate your time, I know this is a large undertaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants