JSON.parse error when wire:initial-data contained " before renderWithRootAttribute

[adamwaclawczyk]

Hey - sorry if this isn't the best place for such discussion. I wanted to also make this visible so others with similar issue could hopefully find this.
I have a question regarding responsibility for ensuring that wire:initial-data contains valid data, we have a 3rd party module that during "add_shipping_info" event in \Amasty\GA4HyvaCheckout\Magewire\Checkout\CheckoutEventListener::evaluateCompletion returns

        return $resultFactory->createSuccess()
            ->withCustomEvent($this->getEventListenerName())
            ->withDetails(['eventData' => $eventData]);

This $eventData contains some product name, stored after using $this->escaper->escapeHtml($productName), example below(note the ")

[{"ecommerce":null},{"event":"add_shipping_info","ecommerce":{"shipping_tier":"test","items":[{"item_name":"test 2" test","item_id":"6535A","item_brand":"test","currency":"PLN","item_category":"test","quantity":1,"price":240}]}}]

So now, the problem: later in magewirephp \Magewirephp\Magewire\Model\Response::renderWithRootAttribute is called and which encodes all other " as " which causes const initialData = JSON.parse(this.el.getAttribute('wire:initial-data')) to fail, because of unexpected " character.

I'm torn since Magento allows " characters in Product Names, I don't think it's fully Amasty's fault for using escapeHtml. For now we removed " characters from production products until we provide a better fix or wait for Amasty to provide a fix so the the $eventData always contains valid, supported by magewirephp data. I'm open to suggestions since ultimately the error is with encoded by Magewire data.

The error:

Uncaught SyntaxError: JSON.parse: expected ',' or '}' after property value in object at line 1 column 1392 of the JSON data

[adamwaclawczyk]

For anyone who ends up here, newer version of the conflicting module was provided that uses $this->escaper->escapeJs($eventData).