Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the payment options (bank card, PayPal, POLi Payments) top-level (in the same way as I have it implemented in my Moip module) #27

Closed
dmitrii-fediuk opened this issue Nov 16, 2017 · 3 comments
Closed

Make the payment options (bank card, PayPal, POLi Payments) top-level (in the same way as I have it implemented in my Moip module) #27

dmitrii-fediuk opened this issue Nov 16, 2017 · 3 comments
Labels
enhancement

Comments

@dmitrii-fediuk
Copy link
Member

01

I need to implement it in the core:

mage2pro/core#44 (Provide a generic (reusable) way to a payment module to provide multiple top-level payment options like currently mage2pro/moip does)
@dmitrii-fediuk dmitrii-fediuk changed the title Make the payment options top-level (in the same way as I have it implemented in Moip) Make the payment options (bank card, PayPal, POLi Payments) top-level (in the same way as I have it implemented in Moip) Nov 16, 2017
@dmitrii-fediuk dmitrii-fediuk changed the title Make the payment options (bank card, PayPal, POLi Payments) top-level (in the same way as I have it implemented in Moip) Make the payment options (bank card, PayPal, POLi Payments) top-level (in the same way as I have it implemented in my Moip module) Nov 16, 2017
This was referenced Nov 20, 2017
Closed
Open
@dmitrii-fediuk
Copy link
Member Author

I need to fix mage2pro/core#61 first («Argument 1 passed to dfa() must be of the type array, null given, called in mage2pro/core/Payment/Comment/Description.php on line 36» is a non-standard config_path is defined for the description field)

@dmitrii-fediuk
Copy link
Member Author

mage2pro/core#61 is fixed.

dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
333c263
dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
72fae90
dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
ee6afed
dmitrii-fediuk added a commit to mage2pro/core that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
63634ec
dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
7437cc3
dmitrii-fediuk added a commit to mage2pro/core that referenced this issue Dec 12, 2017
@dmitrii-fediuk
3.4.10: mage2pro/alphacommercehub#27
be46c70
dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
d2a229d
dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
e709546
dmitrii-fediuk added a commit that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
7aaeb9f
dmitrii-fediuk added a commit to mage2pro/core that referenced this issue Dec 12, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
0a9549e
dmitrii-fediuk added a commit that referenced this issue Dec 13, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
6a19634
dmitrii-fediuk added a commit that referenced this issue Dec 13, 2017
@dmitrii-fediuk
https://github.com/mage2pro/alphacommercehub/issues/27
5759300
dmitrii-fediuk added a commit that referenced this issue Dec 13, 2017
@dmitrii-fediuk
0.7.1
8d43155 
#27
#42
@dmitrii-fediuk
Copy link
Member Author

Implemented in 0.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitrii-fediuk