Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose optional keyword for proto3 #68

Open
mwatson2 opened this issue May 10, 2022 · 1 comment
Open

Expose optional keyword for proto3 #68

mwatson2 opened this issue May 10, 2022 · 1 comment

Comments

@mwatson2
Copy link

Hi @mafintosh - optional in proto3 has the meaning that the absence of the field can be distinguished from its default value. At the moment this module is swallowing all occurrences of the optional keyword so that users cannot see when fields have been marked this way.

I would suggest adding an optional boolean beside required and repeated. required would still always be false for proto3.

Would you accept a PR with this change ?

@mwatson2
Copy link
Author

Here is a Pull Request: #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant