Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch class #394

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: fetch class #394

merged 1 commit into from
Nov 25, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Nov 22, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

the class 0x371b5f7c5517d84205365a87f02dcef230efa7b4dd91a9e4ba7e04c5b69d69b has an empty ABI, which causes a deserialization error when fetching from the sequencer.

Resolves: #NA

What is the new behavior?

  • ensured compatibility with the deserialization process when fetching data from the sequencer
  • added necessary tests to verify the fix and prevent regression

Does this introduce a breaking change?

No

Other information

@jbcaron jbcaron self-assigned this Nov 22, 2024
@jbcaron jbcaron added bug Something isn't working full node Full Node only related issues labels Nov 22, 2024
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

Copy link
Contributor

@Mohiiit Mohiiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antiyro antiyro merged commit 830e95e into main Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working full node Full Node only related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants