feat(stop): added stop_node admin rpc endpoint
#391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be handled by an external proxy anyways.
This currently only contains the `MadaraWriteRpc` methods but will be used to encapsulate any sensitive admin methods in the future.
…edundant mp_block::BlockId
This will allow passing `cancellation_token` to Starknet so rpc methods can stop the node if necessaary.
Trantorian1
changed the title
stop_node admin rpc endpoint to stop a madara node at a distance.stop_node admin rpc endpoint
Trantorian1
force-pushed
the
feat/stop_node
branch
from
5e48088
to
0d75dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
There is no way to stop a Madara node through RPC. This is a small part of an upcoming pr enabling automatic database migration between nodes on a same network.
What is the new behavior?
node_stoprpc method, which can only be called from theadminrpc endpoint.tokio_util::sync::CancellationTokenthrough theStarknetstruct. This is necessary for the above to be possible.Warning
This should be merged after #390
Does this introduce a breaking change?
No.