Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/batch forward #214

Closed
wants to merge 23 commits into from
Closed

Features/batch forward #214

wants to merge 23 commits into from

Conversation

p-ferreira
Copy link
Contributor

@p-ferreira p-ferreira commented Apr 19, 2024 •
edited
Loading

Adds manual batch retrieval system for wikipedia with aiohttp.

  • runs black
  • adds batch dataset abstraction
  • adds batch wiki dataset
  • separate wikipedia utils code to keep dataset file cleaner
  • adds aiohttp async wiki retrieval
  • adds --neuron.batch_size config
  • adds unit tests to batch wiki implementation
  • adds black check to gh action

@p-ferreira p-ferreira requested a review from steffencruz April 19, 2024 20:07
steffencruz
steffencruz reviewed Apr 23, 2024
View reviewed changes
prompting/tools/datasets/base.py Outdated Show resolved Hide resolved
prompting/tools/datasets/batch_wiki.py Outdated Show resolved Hide resolved
prompting/tools/datasets/batch_wiki.py Outdated Show resolved Hide resolved
prompting/utils/async_wiki_utils.py Outdated Show resolved Hide resolved
prompting/utils/config.py Outdated Show resolved Hide resolved
prompting/tools/datasets/base.py Show resolved Hide resolved
prompting/tools/datasets/base.py Show resolved Hide resolved
prompting/tools/datasets/base.py Outdated Show resolved Hide resolved
prompting/utils/async_wiki_utils.py Outdated Show resolved Hide resolved
prompting/utils/async_wiki_utils.py Show resolved Hide resolved
@steffencruz
Copy link
Collaborator

Am I correct in thinking that the batch context class is not exposed publicly or used by the validator in this PR?

p-ferreira and others added 11 commits April 24, 2024 15:58
@p-ferreira @steffencruz
Update prompting/tools/datasets/base.py
6d4d14a 
Co-authored-by: Steffen Cruz <[email protected]>
@p-ferreira @steffencruz
Update prompting/tools/datasets/batch_wiki.py
d7157b8 
Co-authored-by: Steffen Cruz <[email protected]>
@p-ferreira @steffencruz
Update prompting/tools/datasets/batch_wiki.py
8e4af7c 
Co-authored-by: Steffen Cruz <[email protected]>
@p-ferreira @steffencruz
Update prompting/utils/config.py
d886fb5 
Co-authored-by: Steffen Cruz <[email protected]>
@p-ferreira
drops redundant class
6ddf250
@p-ferreira
complements unit tests assertions
52a0309
@p-ferreira
Merge branch 'features/batch-forward' of https://github.com/opentenso…
fcc6e88 
…r/prompting into features/batch-forward
@p-ferreira
adds stats for context obj
7b4d343
@p-ferreira @steffencruz
Update prompting/tools/datasets/base.py
e7129b9 
Co-authored-by: Steffen Cruz <[email protected]>
@p-ferreira
modifies random_batch naming to just random
f50d547
@p-ferreira
adds docs strings
6f33c6d
@p-ferreira
Copy link
Contributor Author

p-ferreira commented Apr 24, 2024 •
edited
Loading

Am I correct in thinking that the batch context class is not exposed publicly or used by the validator in this PR?

You are, the code is added and integrated to the repo but there is no implemented flow that leads to the creation of this object, as downstream implementation would be necessary. We could even merge this into staging if we want, let me know your thoughts on how you want to handle this branch development.

@p-ferreira p-ferreira mentioned this pull request Apr 29, 2024
Open
@p-ferreira p-ferreira linked an issue Apr 29, 2024 that may be closed by this pull request
Add black in CI pipeline #199
Open
@Hollyqui Hollyqui deleted the branch features/throughput-staging August 2, 2024 08:22
@Hollyqui Hollyqui closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffencruz steffencruz steffencruz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add black in CI pipeline
3 participants
@p-ferreira @steffencruz @Hollyqui