Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get_random_uids tests #154

Open
steffencruz opened this issue Mar 12, 2024 · 0 comments
Open

Improve get_random_uids tests #154

steffencruz opened this issue Mar 12, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@steffencruz
Copy link
Collaborator

We should also test that the uids function raises a specific warning/error under certain conditions.

  1. len(uids)<k should log a bt.logging.warning
  2. len(uids)=0 should raise a ValueError

Copied from #142
@p-ferreira p-ferreira added the good first issue Good for newcomers label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steffencruz @p-ferreira